Skip to content

Conversation

irenepsmith
Copy link
Contributor

aws-doc-sdk-examples Pull Request

Thank you for making a submission to the aws-doc-sdk-examples repository. For more information about submitting pull requests to this repository, see Guidelines for contributing.

NOTE: This pull request (PR) template contains two sections. Use the section that applies to your submission, and remove the section which doesn't apply.


I'm submitting a new SDK code example

Confirm you have met the following minimum requirements:

  • Add the following copyright notice to the top of each file. See the LICENSE agreement for the terms of the copyright.

Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
SPDX-License-Identifier: Apache-2.0

  • Create unit tests for all paths through the code, and confirm that the all the tests pass. For recommendations, see How we test code examples.
  • Run a linter against all code and implement the resulting suggestions. For recommendations, see Linters run on check in.
  • Add minimum usage documentation as comments in the code. For recommendations, see Code comment guidelines.

Open source license adherence

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@rlhagerm rlhagerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, just a few questions and comments.

Copy link
Contributor

@lkdavies lkdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments

@github-actions github-actions bot removed the tool/cdk label Dec 21, 2022
@beqqrry-aws beqqrry-aws merged commit 3dcc134 into awsdocs:main Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants