-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Aurora Serverless PHP Backend #3272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s tracker app. Also, made some minor changes to the front end.
…s tracker app. Also, made some minor changes to the front end.
…examples into php-rds-backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functional parts of the code look good to me (a few nitpicks here and there).
However, overall, I'd prefer that we remove any files or code that aren't used in the example. I'm not that familiar with Laravel, but a lot of these files (and parts of files) look like they were created as part of a 'create new project' script, so unless they're strictly required I'd clean them all out to reduce clutter and confusion.
Also: unit tests?
php/cross_service/aurora_item_tracker/app/Http/Middleware/Authenticate.php
Outdated
Show resolved
Hide resolved
php/cross_service/aurora_item_tracker/app/Providers/AppServiceProvider.php
Show resolved
Hide resolved
…examples into php-rds-backend
…ch is handled by testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial comments
…examples into php-rds-backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor README suggestions, otherwise approved!
…examples into php-rds-backend
All the files required for running the PHP - Laravel Aurora Work Items tracker app. Also, made some minor changes to the front end.
aws-doc-sdk-examples Pull Request
Thank you for making a submission to the aws-doc-sdk-examples repository. For more information about submitting pull requests to this repository, see Guidelines for contributing.
NOTE: This PR template contains three sections. Depending on the reason for your pull request, please fill out the section that applies to you and then remove the other two sections.
New SDK Code Example
The submitter has:
Existing Example Update
The submitter has:
Resolve Issue
Issue #
Description of Changes
Please describe the changes you have made here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.