refactor(unix_signal): provide a conservative table size#4069
Open
cnjhb wants to merge 1 commit intoawesomeWM:masterfrom
Open
refactor(unix_signal): provide a conservative table size#4069cnjhb wants to merge 1 commit intoawesomeWM:masterfrom
cnjhb wants to merge 1 commit intoawesomeWM:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4069 +/- ##
==========================================
+ Coverage 90.44% 90.46% +0.01%
==========================================
Files 939 940 +1
Lines 60346 60348 +2
Branches 1145 1145
==========================================
+ Hits 54582 54592 +10
+ Misses 5254 5249 -5
+ Partials 510 507 -3
🚀 New features to boost your workflow:
|
actionless
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the signal values are not consecutive, a conservative size is used to avoid wasting memory. However, even this conservative size reduces the number of table expansions.
Modern compilers are smart enough that the initial statistics should not incur any performance overhead.