Skip to content

Conversation

@mcgitty
Copy link

@mcgitty mcgitty commented Jul 10, 2023

Description

This property is noted in jmeter.log and proven to be correct when referenced in test plan as ${__P(jmeter.reportgenerator.outputdir,)}. However, it not documented here and is unclear whether property "jmeter.reportgenerator.exporter.html.property.output_dir" was incorrectly named.

This property is noted in jmeter.log and proven to be correct when referenced in test plan as ${__P(jmeter.reportgenerator.outputdir,)}. However, it not documented here and is unclear whether property "jmeter.reportgenerator.exporter.html.property.output_dir" was incorrectly named.
@vlsi
Copy link
Collaborator

vlsi commented Jul 10, 2023

Judging by the code, they both should work:

// Get output directory property value
File outputDir = getPropertyFromConfig(exportCfg, OUTPUT_DIR,
new File(JMeterUtils.getJMeterBinDir(), OUTPUT_DIR_NAME_DEFAULT), File.class);
String globallyDefinedOutputDir = JMeterUtils.getProperty(JMeter.JMETER_REPORT_OUTPUT_DIR_PROPERTY);
if(!StringUtils.isEmpty(globallyDefinedOutputDir)) {
outputDir = new File(globallyDefinedOutputDir);
}

jmeter.reportgenerator.exporter.html.property.output_dir is a property for HTML reporter, while jmeter.reportgenerator.outputdir is a global default for all reporters.

@mcgitty
Copy link
Author

mcgitty commented Jul 10, 2023

The first issue, should "jmeter.reportgenerator.outputdir" be documented here?

@vlsi
Copy link
Collaborator

vlsi commented Jul 10, 2023

I think it should. However, I am not sure what sould be the documentation so it is right and non-confusing

@vlsi vlsi changed the title Add jmeter.reportgenerator.outputdir property Document jmeter.reportgenerator.outputdir property Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants