Skip to content

Commit 64854bb

Browse files
nielmmanitgupta
andauthored
Revert "Set setFailIfPoolExhausted in SessionPoolOptions for SpannerAccessor" (#32694) (#32702)
This reverts commit efee92b. Co-authored-by: Manit Gupta <manitgupta@google.com>
1 parent 8eef4a3 commit 64854bb

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import com.google.cloud.spanner.DatabaseAdminClient;
3131
import com.google.cloud.spanner.DatabaseClient;
3232
import com.google.cloud.spanner.DatabaseId;
33-
import com.google.cloud.spanner.SessionPoolOptions;
3433
import com.google.cloud.spanner.Spanner;
3534
import com.google.cloud.spanner.SpannerOptions;
3635
import com.google.cloud.spanner.v1.stub.SpannerStubSettings;
@@ -233,9 +232,7 @@ static SpannerOptions buildSpannerOptions(SpannerConfig spannerConfig) {
233232
if (credentials != null && credentials.get() != null) {
234233
builder.setCredentials(credentials.get());
235234
}
236-
SessionPoolOptions sessionPoolOptions =
237-
SessionPoolOptions.newBuilder().setFailIfPoolExhausted().build();
238-
builder.setSessionPoolOption(sessionPoolOptions);
235+
239236
return builder.build();
240237
}
241238

sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessorTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
package org.apache.beam.sdk.io.gcp.spanner;
1919

2020
import static org.junit.Assert.assertEquals;
21-
import static org.junit.Assert.assertNotNull;
2221
import static org.mockito.ArgumentMatchers.eq;
2322
import static org.mockito.Mockito.times;
2423
import static org.mockito.Mockito.verify;
@@ -164,6 +163,5 @@ public void testBuildSpannerOptionsWithCredential() {
164163
assertEquals("project", options.getProjectId());
165164
assertEquals("test-role", options.getDatabaseRole());
166165
assertEquals(testCredential, options.getCredentials());
167-
assertNotNull(options.getSessionPoolOptions());
168166
}
169167
}

0 commit comments

Comments
 (0)