-
Notifications
You must be signed in to change notification settings - Fork 767
Update porting guide about undefined variable error #3202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Akasurde
wants to merge
2
commits into
ansible:devel
Choose a base branch
from
Akasurde:porting_guide_var_files
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oraNod
reviewed
Dec 11, 2025
oraNod
reviewed
Dec 11, 2025
samccann
reviewed
Dec 15, 2025
Contributor
samccann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a minor suggested change.
Collaborator
felixfontein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR uses both var_files (3 x) and vars_files (5 x). I think it should always be vars_files?
* With 2.19, undefined variable in var_files raises an error Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com> Co-authored-by: Don Naro <dnaro@redhat.com> Co-authored-by: Sandra McCann <samccann@redhat.com>
Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
f9bb93b to
e815987
Compare
felixfontein
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-2.19
Automatically create a backport for the stable-2.19 branch
backport-2.20
Automatically create a backport for the stable-2.20 branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Signed-off-by: Abhijeet Kasurde Akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
docs/docsite/rst/porting_guides/porting_guide_core_2.19.rst