Skip to content

fix: Pass disabled prop to hidden input in NumberField #8706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tklepzig
Copy link

When passing isDisabled to the NumberField, it was not passed to the underlying hidden input, which is rendered when a name prop is given.
This currently results in the value of the NumberField being included in the form values when submitting a form, even if it is disabled.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@tklepzig tklepzig force-pushed the fix-number-field-missing-disabled branch from 0f24860 to ae3925a Compare August 12, 2025 09:07
@tklepzig
Copy link
Author

Closing and reopening to retrigger the Adobe CLA check.

@tklepzig tklepzig closed this Aug 12, 2025
@tklepzig tklepzig reopened this Aug 12, 2025
@tklepzig tklepzig changed the title Pass disabled prop to hidden input in NumberField fix: Pass disabled prop to hidden input in NumberField Aug 12, 2025
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that, looks correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants