-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Open
Labels
Description
Describe the bug
After commit 7b8a205 (introduced in PR #3774), onBlur in EditCell no longer fires if the user finishes editing by clicking on another cell.
To Reproduce
- In
src/editors/textEditor.ts
, add console.log('onBlur') in onBlur.
onBlur={() => {
console.log('onBlur');
onClose(true, false);
}}
- Start the dev server, open the AllFeatures example, double-click any First name cell to enter edit mode, then click a different cell.
Expected behavior
'onBlur' should be printed in the console.
Link to Minimal Reproducible Example
Environment
react-data-grid
version: beta.55react
/react-dom
version:
Additional context
#3774 changed the way to capture the selecting cell.
After this PR, the onBlur is not called anymore.
- The mouse down event in another cell is called to change the
selectedPosition
. getCellEditor
inDataGrid
returns undefined because ofselectedPosition.mode === 'SELECT'
. This early return causes unmount of EditCell before onBlur.
kuoruan