allowing PhoneNumberField to be read as well #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to bump this, but is there any reason why this is not yet merged? |
taylor-shift
approved these changes
Jul 20, 2019
|
@aaronn , Hey Aaron. Any chance you can merge this pull request real quick? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like using this package: https://github.com/stefanfoulis/django-phonenumber-field because it's very thorough in cleaning phonenumber's.
However at the moment it can't be used. Don't know if this is the right way to go about this. But I didn't want to bother you with an extra dependency. So now I check if the name of the class is 'PhoneNumber'.
Let me know if you have questions.