Update compilation.md with automated script.#1150
Open
ccorcos wants to merge 1 commit intoWiseLibs:masterfrom
Open
Update compilation.md with automated script.#1150ccorcos wants to merge 1 commit intoWiseLibs:masterfrom
ccorcos wants to merge 1 commit intoWiseLibs:masterfrom
Conversation
mceachen
reviewed
Mar 10, 2024
| mkdir -p sqlite-amalgamation | ||
| cd sqlite-amalgamation | ||
|
|
||
| curl -O https://sqlite.com/2024/sqlite-amalgamation-3450100.zip |
Member
There was a problem hiding this comment.
Thanks for taking the time to write this PR!
Unfortunately, I suspect people will blindly copy and paste this in the future and not realize they're pulling in an out of date amalgamation (this library is popular, and people open spurious bugs continuously. I suspect this will be a new source.)
If you want to be fancy, you can do something like this, which would be evergreen.
- do the
npm install better-sqlite3first. - then
mkdir -p sqlite-amalgamation && cd sqlite-amalgamation - then something like this:
source <(egrep "^(YEAR|VERSION)=" ../node_modules/better-sqlite3/deps/download.sh)
curl https://sqlite.org/$YEAR/sqlite-amalgamation-$VERSION.tar.gz | tar -xz --strip 1
To fetch and extract into your new dir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.