Improve color contrast handling #100
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravewebdev
force-pushed
the
enhancement/99-improve-color-contrast-handling
branch
from
ca0a0bc to
0a176ad
Compare
ravewebdev
force-pushed
the
enhancement/99-improve-color-contrast-handling
branch
from
0a176ad to
8be22ed
Compare
added 5 commits
September 11, 2020 16:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99
Description
Updates
Slideblock to only renderSettingspanel if block selected.Adds hook,
useMediaAverageColor, to determine average color of media element.Updates
fontColorcontrast check to include background overlay and average media color.Screenshot
Steps to verify the solution
How will a stakeholder test this? Please list the steps.
Other