Update visual mode cursors (rebase of #5314) #7140
Open
+17
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes the hardcoded cursor colors used in visual mode, now it uses the css 'mix-blend-mode: difference' property to make the color be the opposite of the block cursor color. This is the same thing vscode does, except they actually calculate the value instead of using the css property. The result however is the same color.
|
Sounds good- i'll see if I can make the config change |
|
Any update on this, @fafrd? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to get #5314 merged in.
This PR is a rebase of 5314 against master. This should be safe to merge in, #5314 appeared to have consensus to merge.
Ultimately this would resolve issue #5294.
cc @J-Fields @berknam