Skip to content

Conversation

@noah0316
Copy link
Member

🟣 관련 이슈

🟣 구현/변경 사항 및 이유

저장 프로세스 기능구현을 위한 Share Extension Target을 추가했습니다.
commit : 19bff5d

🟣 PR Point

🟣 참고 사항

@noah0316 noah0316 added 🗂 승현 SeungHyun's work ⚙️ Setting Project Setting 🟣 Share 공유하기 뷰 labels Jan 14, 2022
@noah0316 noah0316 self-assigned this Jan 14, 2022
Copy link
Member

@Suyeon9911 Suyeon9911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어용 ~~ 홍선배꽈리 ~~~

@SwiftLint-Bot
Copy link
Collaborator

SwiftLint-Bot commented Jan 14, 2022

All File Checked 📝

LGTM✨ No Errors or Warnings Found

Good Job!

SwiftLint all file passed!! 고생하셨습니다!!

Generated by 🚫 Danger


import UIKit

@objc(ShareViewController)
Copy link
Contributor

@sujinnaljin sujinnaljin Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3;
해당 코드가 의미하는 바는 무엇이고 왜 필요한건가요??

Copy link
Member Author

@noah0316 noah0316 Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sujinnaljin
팀이 지향하는 바가 스토리보드 없이 UI를 구성하는 것이기에 스토리보드(MainInterface.storyboard)를 먼저 삭제했습니다.

기존에는 ShareViewController를 MainInterface.storyboard를 통해 팝업시켜주었습니다.
스토리보드가 사라졌기에 Share Extension에 접근시 가장 먼저 띄워줄 EntryViewController(NSExtensionPrincipalClass)를 지정해주어야합니다.

따라서 해당 컨트롤러를 NSExtensionPrincipalClass로 지정해주기 위해 @objc(ShareViewController)를 이용해 objc runtime에 접근 가능하게 해주었습니다!

Copy link
Contributor

@sujinnaljin sujinnaljin Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 그래서 저 위에 요렇게 설정되어있는거군요

<key>NSExtensionPrincipalClass</key>
		<string>ShareViewController</string>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 맞습니다!!!

Copy link
Contributor

@sujinnaljin sujinnaljin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

긋~

@noah0316 noah0316 requested a review from beansbin January 14, 2022 16:10
Copy link
Member

@beansbin beansbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

홍선배 멋쪄요~!!

Copy link
Member

@YoonAh-dev YoonAh-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멋지네요~👍

@noah0316 noah0316 merged commit 9ad03aa into develop Jan 14, 2022
@noah0316 noah0316 deleted the feature/37-share-extension branch January 14, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️ Setting Project Setting 🗂 승현 SeungHyun's work 🟣 Share 공유하기 뷰

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ADD] Share Extension Target 추가

7 participants