Added option to show bottom sheet instead of dialog #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosenpin
changed the title
|
why this branch not merge yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
setBottomSheetfunction that causes the initial rating dialog to pop up as a bottom sheet instead of as a dialog.Bottom sheets are less intrusive and more in line with Google's own rating library so I figured it would be a good fit.
P.S.
I have 2 other branches that are based on this one in my fork
https://github.com/rosenpin/awesome-app-rating/tree/feature/skip-prompt
https://github.com/rosenpin/awesome-app-rating/tree/feature/confirm-on-rating-selected
It would have been better to separate them so I could open 3 PRs but this bottom sheet one caused some relatively significant changes in the DialogManager class and I wanted to avoid later conflicts.
So for now, I will wait for this PR to be merged before opening the 2 other PRs.