Merged
Conversation
the logic surface size may not be equal to the buffer size of a viewport has been attached to the surface.
contains_rect had a copy and paste error
cmeissl
force-pushed
the
feature/opaque_regions
branch
2 times, most recently
from
96fe3ae to
755ecb3
Compare
Drakulix
reviewed
Jul 6, 2022
Member
Drakulix
left a comment
Drakulix
left a comment
There was a problem hiding this comment.
Looks good to me except for the missing docs!
cmeissl
force-pushed
the
feature/opaque_regions
branch
4 times, most recently
from
bed438c to
eebce85
Compare
add support for subtracting a rectangle from another
export the surface opaque regions in the RendererSurfaceState
the opaque regions are used to reduce the damage
cmeissl
force-pushed
the
feature/opaque_regions
branch
from
eebce85 to
9f17145
Compare
Drakulix
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for opaque regions in the renderer and extends the space to skip damage when applicable