xdg_activation: Allow passing all data in XdgActivationState::create_external_token#1658
Merged
PolyMeilex merged 1 commit intoSmithay:masterfrom Feb 24, 2025
Conversation
Member
|
This seems fine, but what is the use case for pretending that a given surface created the token when in fact it didn't? |
PolyMeilex
reviewed
Feb 23, 2025
Merged
Contributor
Author
|
My use case is to workaround the lack of terminal xdg-activation support (see VTE issue, ghostty discussion, it seems unlikely to be solved soon) for implementing xdg-activation based window swallowing which is particularly useful for terminals. |
PolyMeilex
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure about the api style, alternatively this could return a
&mut XdgActivationTokenDatainstead and drop the argument. This is breaking, but not for the common case ofactivation_state.create_external_token(None).Example usage in niri ipc (not upstreamed), creating an activation token as if it was created by the focused/requested window: