rename Rectangle::from_extemities to Rectangle::from_extremeties #1646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a function under the old name still exists, but it just calls `from_extremeties` under the hood, is not on the documentation and is deprecated, so that this is not a breaking change. the actual word is called "extremities", extemities is just a misspelling, see https://en.wiktionary.org/wiki/extremities.
PolyMeilex
approved these changes
Feb 13, 2025
Member
|
Thanks! |
Contributor
|
The PR title itself contains a typo in the new name which threw me off, but the diff seems to be correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a typo in the function name: "extremities" is the correct name, "extemities" is just a misspelling
the function is not that common to call from outside of smithay, anvil don't use it at all, cosmic uses it exactly once and niri only three times, but it is still a breaking change, so i just deprecated it and hid it on the docs instead of removing it.