Skip to content

Conversation

@YaLTeR
Copy link
Contributor

@YaLTeR YaLTeR commented Feb 8, 2024

Taking over from #1021, cc @PolyMeilex @chrisduerr.

Changes:

  1. Added notify_activity(&Seat), kept the WlSeat method under a different name.
  2. Fixed a bug where uninhibiting didn't reset idle state resulting in two subsequent resumed events (forbidden by the protocol).
  3. Added dead WlSeat data cleanup.
  4. Some other minor things.

Impl in niri: YaLTeR/niri@main...idle-notify

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

Attention: 177 lines in your changes are missing coverage. Please review.

Comparison is base (1074914) 21.48% compared to head (965921a) 21.32%.

Files Patch % Lines
src/wayland/idle_notify/mod.rs 0.00% 177 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
- Coverage   21.48%   21.32%   -0.17%     
==========================================
  Files         155      156       +1     
  Lines       24944    25121     +177     
==========================================
- Hits         5359     5356       -3     
- Misses      19585    19765     +180     
Flag Coverage Δ
wlcs-buffer 18.41% <0.00%> (-0.14%) ⬇️
wlcs-core 18.09% <0.00%> (-0.13%) ⬇️
wlcs-output 7.75% <0.00%> (-0.06%) ⬇️
wlcs-pointer-input 20.17% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@PolyMeilex PolyMeilex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern with this code was lack of compositor implementation, but if we have niri code, I'm fine with it now.

LGTM, not going to merge it tho, as that would kinda be me reviewing my own code 😃

@PolyMeilex PolyMeilex merged commit 774e45a into Smithay:master Feb 9, 2024
@PolyMeilex
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants