Feature/software renderer by cmeissl · Pull Request #1228 · Smithay/smithay

cmeissl · 2023-11-13T19:25:08Z

This PR adds a new pixman based software renderer

TODO:

Docs
~~Anvil~~ will be done in a separate PR
pixman-rs release
cleanup drm fb exporter

src/backend/renderer/pixman/mod.rs

src/backend/allocator/dmabuf.rs

codecov-commenter · 2023-11-26T19:52:32Z

Codecov Report

Attention: 79 lines in your changes are missing coverage. Please review.

Comparison is base (ee02198) 21.61% compared to head (6ce537c) 21.54%.

Files	Patch %	Lines
src/backend/allocator/dmabuf.rs	0.00%	79 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1228      +/-   ##
==========================================
- Coverage   21.61%   21.54%   -0.07%     
==========================================
  Files         155      155              
  Lines       24718    24797      +79     
==========================================
  Hits         5342     5342              
- Misses      19376    19455      +79

Flag	Coverage Δ
wlcs-buffer	`18.61% <0.00%> (-0.06%)`	⬇️
wlcs-core	`18.27% <0.00%> (-0.06%)`	⬇️
wlcs-output	`7.62% <0.00%> (-0.03%)`	⬇️
wlcs-pointer-input	`20.34% <0.00%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/backend/allocator/dumb.rs

src/backend/allocator/dmabuf.rs

bwidawsk · 2023-11-28T18:33:32Z

src/backend/drm/dumb.rs

+    let (fb, format) = match ret {
+        Ok(fb) => fb,
+        Err(source) => {
+            let fourcc = format.code;


I think it'd be worth putting a debug!() here since most/all drivers we use should support addfb2, and this fallback shouldn't happen

You mean a log message? So more like a tracing::warn?

If a warn!, we should make sure to not send this on every occurrence, but once.

Added a warn wrapped in an Once::call_once to warn once about the legacy fallback path

src/backend/renderer/pixman/error.rs

src/backend/renderer/pixman/mod.rs

Drakulix · 2023-11-30T19:48:50Z

Before I forget, can we please reexport the pixman crate either in the reexports module or in backend::renderer::pixman given some types are part of the public api? (E.g. in From<pixman::Image> for PixmanRenderBuffer)

cmeissl · 2023-12-26T18:52:42Z

Before I forget, can we please reexport the pixman crate either in the reexports module or in backend::renderer::pixman given some types are part of the public api? (E.g. in From<pixman::Image> for PixmanRenderBuffer)

Added under re-exports

this allows the resulting dmabuf to be mapped read/write for rendering

this allows to create a dumb buffer allocator from an open drm device fd.

Drakulix

LGTM!

Drakulix reviewed Nov 13, 2023

View reviewed changes

src/backend/renderer/pixman/mod.rs Outdated Show resolved Hide resolved

ids1024 reviewed Nov 13, 2023

View reviewed changes

src/backend/renderer/pixman/mod.rs Outdated Show resolved Hide resolved

cmeissl force-pushed the feature/software_renderer branch from 1b691a2 to 5525fee Compare November 13, 2023 21:42

Drakulix reviewed Nov 16, 2023

View reviewed changes

src/backend/allocator/dmabuf.rs Outdated Show resolved Hide resolved

cmeissl force-pushed the feature/software_renderer branch 4 times, most recently from dc4b5aa to 78215a2 Compare November 26, 2023 19:45

cmeissl force-pushed the feature/software_renderer branch 2 times, most recently from fa3498a to f0f4ae7 Compare November 28, 2023 15:47

cmeissl marked this pull request as ready for review November 28, 2023 16:19