-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] Re-pack Selenium Manager as native dependency #16048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
c75901c
Move assets to nuget directory
nvborisenko 34d5be5
Fix dotnet build
nvborisenko 4754394
Import shared targets
nvborisenko 33c2234
Import targets
nvborisenko a0cd824
Fix dotnet build
nvborisenko abc0858
Support buildMultiTargeting
nvborisenko 8a747d1
Update Selenium.WebDriver.csproj
nvborisenko 050c3dd
Pack as native dependency
nvborisenko 715d7b6
dotnet pack
nvborisenko 47b2065
Update Selenium.WebDriver.csproj
nvborisenko 3106d3c
Now it is possible to reference csproj witout any custom targets
nvborisenko b3f29e5
Clean test project
nvborisenko 088e107
Green tests
nvborisenko da351d4
Amazing improvement
nvborisenko 8636b15
Throw if not supported
nvborisenko 86ef405
Remove old targets
nvborisenko e5a0648
Remove unnecessary buildMultiTargeting
nvborisenko 2189a3d
Custom targets for netstandard2.0 only
nvborisenko 8819990
Legacy packages.config support
nvborisenko 2fd1c83
Fix bazel part
nvborisenko 2b32f0f
Add other assets for legacy projects
nvborisenko e68ab2a
Throw fast if provided incorrectly
nvborisenko 7b86af1
Probing couple of potential SM paths
nvborisenko f980107
Single file and AOT
nvborisenko b63491e
Remove temporary fallback
nvborisenko 70009e2
Finally
nvborisenko 5c40a80
Update SeleniumManager.cs
nvborisenko 7ec66a3
Distinct and format error
nvborisenko 5354d1c
Fix bazel, we like it
nvborisenko 10c068d
Fix NullRef
nvborisenko b856428
More explanations
nvborisenko a4be9be
More explanations
nvborisenko 8f7a81f
Format script?
nvborisenko 40cf289
Use Path.PathSeparator
nvborisenko 6d64cd2
Use linq to probe file existance
nvborisenko d4b3da8
Clearer bazel assets target names
nvborisenko e129016
Merge branch 'trunk' into dotnet-sm-native
nvborisenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
More explanations
- Loading branch information
commit a4be9be4381a7cfb01fb625dc388753a7178a911
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.