Skip to content

Replace &*obj as *const T with addr_of #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: rust
Choose a base branch
from
Open

Replace &*obj as *const T with addr_of #747

wants to merge 1 commit into from

Conversation

wcampbell0x2a
Copy link

Normally, clippy will find this. However this lint was missing when doing some manual analysis.

This produces the same code in godbolt.

@bjorn3
Copy link
Member

bjorn3 commented Apr 21, 2022

Looks like your commit message is missing a DCO signoff.

@wcampbell0x2a
Replace &obj as *const T with addr_of
57455ee 
Signed-off-by: wcampbell <wcampbell1995@gmail.com>
@wcampbell0x2a
Copy link
Author

Looks like your commit message is missing a DCO signoff.

Added

@bjorn3
Copy link
Member

bjorn3 commented Apr 21, 2022 •
edited
Loading

You will have to sign off with your full legal name: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bjorn3 bjorn3 bjorn3 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcampbell0x2a @bjorn3