[Feature] REST endpoint to query connected validators #4066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaimast
force-pushed
the
feat/rest-validator-peers
branch
from
c5bbabf to
fa7a220
Compare
kaimast
force-pushed
the
feat/rest-validator-peers
branch
from
fa7a220 to
21740c3
Compare
kaimast
force-pushed
the
feat/rest-validator-peers
branch
2 times, most recently
from
1d84123 to
fd760b3
Compare
kaimast
force-pushed
the
feat/rest-validator-peers
branch
from
fd760b3 to
eb0850e
Compare
esren0x
reviewed
Jan 27, 2026
esren0x
left a comment
esren0x
left a comment
There was a problem hiding this comment.
Noticed README also has the list of routes, but not these new ones.
The new ones from a structure POV look good, just noticed a few extra bits when reviewing. And not sure if you guys usually add integration tests for these?
| elif (( result < min_peers )); then | ||
| log "Node #${node_index} (port=$port) has $result BFT connections, expected at least $min_peers. Will wait and retry..." | ||
| else | ||
| return 0 |
There was a problem hiding this comment.
I might not have full context, but looks like this return would potentially show a "sucess" even tho it failed. By logging and then returning 0 it would appear to have worked and not get tot he message at the end for
log "❌ BFT connections did not reach $min_peers within 5 minutes."
|
|
||
| echo "❌ Benchmark failed! Validators did not sync within 30 minutes." | ||
| log "❌ Benchmark failed! Validators did not sync within 30 minutes." | ||
| print_client_logs "$log_dir" "$num_validators" "$num_nodes" |
There was a problem hiding this comment.
Suggested change
| print_client_logs "$log_dir" "$num_validators" "$num_nodes" | |
| print_validator_logs "$log_dir" $((num_nodes+1)) 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, one can query the connected router peers (through
{network}/peers/..) but not validators connected through the gateway.This PR adds a new set of endpoints
{network}/connection/bft/..and{network}/connections/p2p/... The former allows querying connected validators, while the latter is just an alias for the{network}/peers/..endpoint.Test Plan
The new endpoint is used in the sync benchmark to test that validators are fully connected to each other. Successfully running that benchmark validates that the endpoint works as expected.
Backwards compatibility
Initially, I hoped we could just include the validators in the existing
peersendpoint, but I added the new endpoints to avoid breaking existing functionality.Benchmark fixes
Recent changes on staging broke the benchmark workflow. This PR also contains a commit that fixes the workflow.