-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[jaxrs-spec][quarkus] Feat: Add an option to use "org.jboss.resteasy.reactive.RestResponse" #21877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
thanks for the PR cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) |
|
did you test this PR locally to confirm it works for your use cases? |
|
Hi @wing328, I just tested, and I confirm that version "7.16.0-SNAPSHOT" works on my project 👍 |
|
i tested with but the output won't compile does it work for you locally in your machine? |
|
please also follow step 3 in the PR checklist to update samples and doc |
|
instead of adding a new option, what about updating the existing one |
|
+1 |
Good catch! An issue with the pom.xml. I had an existing pom.xml which is why it worked on my side. I will fix it. |
|
|
|
tested again and the output compiles without issues |
…reactive.RestResponse" (OpenAPITools#21877) * replace Response by RestResponse * fix rest response for Async * update documentation * Add option "returnJBossResponse" * Add tests + fixes * Polish * Add dependency "io.quarkus.resteasy.reactive:resteasy-reactive" when returnJBossResponse=true * fix JavaJAXRSSpecServerCodegenTest * generate samples & docs
PR for #21424
useJBossResponseto use typedorg.jboss.resteasy.reactive.RestResponseinstead ofjavax.ws.rs.core.Response(see here)