Skip to content

Conversation

@devhl-labs
Copy link
Contributor

@devhl-labs devhl-labs commented Jul 26, 2025

Converts existing code into recursive code to better handle nested maps. First of a few PRs to fix issues pointed out by #21585 I don't think sample changes are necessary since its only making existing code recursive.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@devhl-labs devhl-labs changed the title [csharp] Handle nested maps recurssively [csharp] Handle nested maps recursively Jul 26, 2025
protected void patchPropertyIsInherited(CodegenModel model, CodegenProperty property) {
}

private void patchNestedMaps(CodegenProperty property) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: adding a docstring explaining what this function does

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge this and ill send a docstring in the next pr? Ive got three or four others queued up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure bro

@wing328 wing328 merged commit 64e9b37 into OpenAPITools:master Jul 28, 2025
14 checks passed
@devhl-labs devhl-labs deleted the 21585-recursive-maps branch July 28, 2025 03:35
@wing328 wing328 added this to the 7.15.0 milestone Aug 9, 2025
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
* handle nested maps recurssively

* improve git diff readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants