Skip to content

Conversation

@Rym-qt
Copy link
Contributor

@Rym-qt Rym-qt commented May 7, 2025

This PR is related to issue #21239
These newly added flags lay the foundation for future changes in the generator's template files, particularly for the cpp-qt-client.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented May 7, 2025

These newly added flags lay the foundation for future changes in the generator's template files, particularly for the cpp-qt-client.

thanks for the PR

what about including these changes (cpp-qt templates) in this PR as well?

cc @OpenAPITools/generator-core-team

@Rym-qt
Copy link
Contributor Author

Rym-qt commented May 22, 2025

what about including these changes (cpp-qt templates) in this PR as well?

Just to clarify, we're not modifying existing templates, we're introducing a new generator. For example, I'm aiming to reduce the amount of generated code in the operation implementation, as mentioned in the issue description.

@wing328
Copy link
Member

wing328 commented Jun 17, 2025

👌

can you please add some tests in https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultCodegenTest.java to test these new flags to ensure these are working as expected moving forward?

@wing328 wing328 merged commit 4372659 into OpenAPITools:master Jul 16, 2025
4 checks passed
@wing328
Copy link
Member

wing328 commented Jul 16, 2025

just merged it. i'll add some tests later with another pr

thanks for your contribution

@wing328 wing328 added this to the 7.15.0 milestone Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants