Fix #20649 Handling of x-implements for enumeration in java and spring generators #20652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-mfg
suggested changes
Mar 3, 2025
Contributor
martin-mfg
left a comment
martin-mfg
left a comment
There was a problem hiding this comment.
Hi @jpfinne, thanks for the PR!
| public void testEnumWithImplements() { | ||
| final Path output = newTempFolder(); | ||
| final OpenAPI openAPI = TestUtils.parseFlattenSpec("src/test/resources/3_0/enum-implements.yaml"); | ||
| JavaClientCodegen codegen = new JavaClientCodegen(); |
Contributor
There was a problem hiding this comment.
This should be SpringCodegen.
| */ | ||
| @JsonAdapter(EnumClass.Adapter.class) | ||
| public enum EnumClass { | ||
| public enum EnumClass implements Parcelable { |
Contributor
There was a problem hiding this comment.
This change and the change in OuterEnum.java cause compilation errors. Skipping this line for enums should be enough to fix the problem.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review. I'll have a look
Contributor
Author
There was a problem hiding this comment.
@martin-mfg
Indeed Parcelable and enum were wrong.
I had a merge problem
I've created a new PR #20778
Sorry for the inconvenience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20649
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)
Spring:
@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)