Skip to content

Conversation

@danowensdev
Copy link
Contributor

@danowensdev danowensdev commented Dec 4, 2024

Fixes #20248

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@danowensdev danowensdev changed the title typescript-fetch# fix promise return type for optional responses [typescript-fetch] fix promise return type for optional responses Dec 4, 2024
@danowensdev danowensdev changed the title [typescript-fetch] fix promise return type for optional responses [typescript-fetch] fix API signature return type for empty 20x responses Dec 4, 2024
@danowensdev danowensdev marked this pull request as draft December 4, 2024 17:09
@danowensdev danowensdev marked this pull request as ready for review December 5, 2024 07:55
@danowensdev
Copy link
Contributor Author

As per the PR checklist, I am mentioning the typescript technical committee, as the only part changed here is the apis.mustache used by the typescript-fetch generator. @TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka

@macjohnny macjohnny merged commit 387fd99 into OpenAPITools:master Dec 5, 2024
15 checks passed
@wing328 wing328 added this to the 7.11.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][Typescript-fetch]: Conflicting API response signatures where isResponseOptional is true

3 participants