Merged
Conversation
Member
|
Thanks for this fix, @BryonLewis. Has the Poetry bug been reported upstream? If not, can you do so? |
Collaborator
Author
|
I haven't spent significant time searching within the Poetry Github to see if it was a regression, intended change from jumping from 1.1.2 past 1.1.15 and all the way to 1.2.0 or if there is duplicate issue already (poetry has 991 backlogged issues). I imagine we were taking advantage of some quirk which allowed it to identify virtualenvs indirectly. Explicitly stating them allowed us to update to the latest version. I ran the integration tests and they all worked (except one related to updating the addons). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.