Skip to content

equality and hash for terms and schemas #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

equality and hash for terms and schemas #241

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0a6d78d
Overload == and isequal to check schema equality
amCap1712 Mar 9, 2020
1ca55c0
Remove unneccessary changes.
amCap1712 Mar 11, 2020
e6f8b87
Consistent formatting style and add more tests.
amCap1712 Mar 16, 2020
2f03a7c
Update src/terms.jl
Mar 16, 2020
ef367d7
Add more tests.
amCap1712 Mar 16, 2020
993829b
Fix broken tests.
amCap1712 Mar 16, 2020
ee16796
Fix broken tests.
amCap1712 Mar 31, 2020
fcf551d
remove isequal methods (default fallback uses ==)
kleinschmidt Sep 21, 2021
6850ecf
hash schema and test
kleinschmidt Sep 21, 2021
b62009e
hash terms and add a few tests
kleinschmidt Sep 21, 2021
68b240a
test equality of function terms
kleinschmidt Sep 21, 2021
5a932c4
Merge remote-tracking branch 'origin/master' into dfk/equals-hash
kleinschmidt Sep 21, 2021
63e7ff4
one more test, 1.0 struggles with foldr and generators apparently
kleinschmidt Sep 21, 2021
08a6278
define generic fallback for == of AbstractTerms
kleinschmidt Sep 21, 2021
63860c6
whoops
kleinschmidt Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test equality of function terms
  • Loading branch information
@kleinschmidt
kleinschmidt committed Sep 21, 2021
commit 68b240aa1031c6a2425d90b749a453a165d52c2f
23 changes: 22 additions & 1 deletion test/terms.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,5 +159,26 @@ StatsModels.apply_schema(mt::MultiTerm, sch::StatsModels.Schema, Mod::Type) =
end

end


@testset "equality of function terms" begin
# for now, we use `@formula` to construct the function terms
f1 = @formula(0 ~ (1 | x)).rhs
f2 = @formula(0 ~ (1 | x)).rhs
@test f1 !== f2
@test f1 == f2
@test hash(f1) == hash(f2)

f3 = @formula(0 ~ (1 % x)).rhs
@test f1 != f3
@test hash(f1) != hash(f3)

f4 = @formula(0 ~ (x | 1)).rhs
@test f1 != f4
@test hash(f1) != hash(f4)

f5 = @formula(0 ~ (1 & y | x)).rhs
@test f1 != f5
@test hash(f1) != hash(f5)
end

end