LazyLibrary: Make add_dependency! always ephemeral to a given process
#59233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
force-pushed
the
ct/lazylibrary-ephemeral-deps
branch
from
38ec67b to
7669c4b
Compare
topolarity
force-pushed
the
ct/lazylibrary-ephemeral-deps
branch
2 times, most recently
from
87fcc6e to
fed86d9
Compare
Like many registration / hook-like functions in Julia, this function is somewhat dangerous to use at compile-time. Depending on whether the `LazyLibrary` you are adding dependencies to was constructed in a prior pre-compilation process or not, your dependencies may or may not persist. This change errs on the side of consistency, and makes it so that `add_dependency!` is always an ephemeral operation that does not persist beyond the lifetime of the process. This makes it safe to temporarily register dependencies, e.g., during a sysimage build.
topolarity
force-pushed
the
ct/lazylibrary-ephemeral-deps
branch
from
fed86d9 to
ba0fe07
Compare
|
Despite JuliaLang/LinearAlgebra.jl#1407 closing, I think this might be a good change to take anyway. Possibly with a re-name to make it clear that this registration only lasts for the existing process? |
|
I'm totally in favor of anything that makes the semantics around how this interacts with |
staticfloat
approved these changes
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like many registration / hook-like functions in Julia, this function is somewhat dangerous to use at (pre)compile-time. Depending on whether the
LazyLibraryyou are adding dependencies to was constructed in a separate pre-compilation process or not, your dependencies may or may not persist.This change errs on the side of consistency, and makes it so that
add_dependency!is always an ephemeral operation that does not persist beyond the lifetime of the process, which makes it safe to temporarily register dependencies, e.g., during a sysimage build.(originally for JuliaLang/LinearAlgebra.jl#1407)