IJPL-54591: Use XDG Desktop Portal to sync light/dark mode on Linux #3100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the XDG Desktop Portal spec for system settings, now standardized by freedesktop: https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.Settings.html#org-freedesktop-portal-settings-read Specifically, it uses the `org.freedesktop.appearance` `color-scheme` setting to detect whether the user's OS is set to prefer dark mode. To do this, it uses the `dbus-send` and `dbus-monitor` commands, part of the `dbus-bin` package. I'm sure there are Java-DBus interop APIs that could do this more elegantly, but I figured it wasn't worth adding a new dependency for what ends up being a pretty simple check.
iso2013
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the XDG Desktop Portal spec for system settings, now standardized by freedesktop: https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.Settings.html#org-freedesktop-portal-settings-read Specifically, it uses the
org.freedesktop.appearancecolor-schemesetting to detect whether the user's OS is set to prefer dark mode.To do this, it uses the
dbus-sendanddbus-monitorcommands, part of thedbus-binpackage. I'm sure there are Java-DBus interop APIs that could do this more elegantly, but I figured it wasn't worth adding a new dependency for what ends up being a pretty simple check.(I also do not typically work in Kotlin; please let me know if there are ways I can improve my formatting or execution here, and I will gladly do so.)