Skip to content

Conversation

@effectfully
Copy link
Contributor

@effectfully effectfully commented Oct 3, 2018

This adds type synthesis tests and immediately disables them, because there are bugs.

One kind of bug:

              Expected type
                '(fix self (fun self (fun a b)))',
              found type
                '(fix self [(lam a (type) (fun self a)) (fun a b)])'

It seems we do not normalize something properly. I'll take a look and if I won't be able to track this down, I'll ask Vanessa.

Another kind of bug is due to historical reasons where we have integer :: type as opposed to integer :: size -> type (this was the case, right?), so stdlib were written with having the former in mind. I'll fix the stdlib in another PR.

@effectfully effectfully merged commit 90da4da into IntersectMBO:master Oct 3, 2018
@effectfully effectfully deleted the effectfully/CGP-356/type-synthesis-tests branch October 3, 2018 17:17
@mchakravarty
Copy link
Contributor

This adds type synthesis tests and immediately disables them, because there are bugs.

What do you think about add a list of all disabled tests to the README.md of the package? This makes them more visible, so we don't forget to fix them eventually.

@effectfully
Copy link
Contributor Author

What do you think about add a list of all disabled tests to the README.md of the package? This makes them more visible, so we don't forget to fix them eventually.

I think the common thing is to have a folder of failing tests that are not supposed to fail.

Most of the tests from this PR already pass. There are a couple of tests which don't pass, but I plan to work on this on the next week and there is already a related YouTrack ticket (CGP-363), so this is kinda WIP and I do not bother with making those fails explicit to the reader.

@mchakravarty
Copy link
Contributor

@effectfully Well, then let's have a link to the folder with failing test cases. I think, it is good to make this visible. It is too easy to just forget stuff put into a folder down in the hierarchy.

@effectfully
Copy link
Contributor Author

Well, then let's have a link to the folder with failing test cases. I think, it is good to make this visible. It is too easy to just forget stuff put into a folder down in the hierarchy.

Sounds good to me. I'll do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants