Smelteries: Migrate from armor stands to item displays#1272
Open
runcows wants to merge 10 commits intoGamemode4Dev:update-26.1from
Open
Smelteries: Migrate from armor stands to item displays#1272runcows wants to merge 10 commits intoGamemode4Dev:update-26.1from
runcows wants to merge 10 commits intoGamemode4Dev:update-26.1from
Conversation
Bloo-dev
added
the
quality-update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces armor stands with item displays.
Resolves a visual bug with the resource pack, where the smeltery texture doesn't fit the block correctly.
Item displays are all located at the center of the smeltery block and translated to display correctly. This allows us to eliminate a lot of position movements as well as the
gm4_smelt_idscoreboard, due to the fact that every entity of the smeltery is in the exact same spot.Also included is a change to the placement function, moving from 4 functions, one for each cardinal direction, to one which uses macros to control the rotation changes.
There is an upgrade path included, it has been tested thoroughly. In order to retain functionality of legacy smelteries without jankiness, it is also run from
mainbeforeprocess. This ensures that process cannot fail due to legacy entities being present.I'm not sure if I need a score check for the upgrade path manual invocation, currently there is not one.
Due to the upgrade path, the minor version has been bumped. This is of note for #1256 where we want to bump all minor versions anyway.