This repository was archived by the owner on Aug 2, 2022. It is now read-only.
eosiolib Unit/Regression Tests#424
Merged
larryk85 merged 55 commits intorelease/1.6.xfrom Feb 21, 2019
Merged
Conversation
added 30 commits
December 28, 2018 12:46
`name_tests`, `symbol_tests`, `asset_tests`, `system_tests`, and `crypto_tests` now ready
larryk85
suggested changes
Feb 20, 2019
Contributor
larryk85
left a comment
larryk85
left a comment
There was a problem hiding this comment.
asset_tests.cpp has warnings about unused comparisons. at lines 326, 519, 524 and 529. These are not doing anything, please change these to CHECK_EQUAL. Also the CHECK_PRINTs at line 424-436 are not correct and the check is failing. Also, where you are checking the string or print for a negative asset, you are using "--". This is a bug, please look at PR #422 and copy his fix over and fix these tests. You will not be able to simply merge his PR as it will overwrite too many things.
larryk85
approved these changes
Feb 21, 2019
rise-worlds
pushed a commit
to potato-coin/eosio.cdt
that referenced
this pull request
Jul 14, 2020
`eosiolib` Unit/Regression Tests Pipeline is shot, so merging in without full tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In correspondence with issue #376 unit/regression tests have been implemented for the following files:
asset.hppbinary_extension.hppcrypto.hppdatastream.hppfixed_bytes.hppname.hppserialize.hppsymbol.hppsystem.hpptime.hppvarint.hppThis will ensure that the integrity of the data structures and their respective methods in directory
eosio.cdt/libraries/eosiolib/will remain steadfast and consistent throughout any change that might happen to the library in the future.To run the tests simply enter the build directory (where my generated build directory is
eosio.cdt/build/) and run thectestcommand.For example:
~/eosio.cdt/build$ ctest