-
-
Notifications
You must be signed in to change notification settings - Fork 695
Add option to deactivate old project versions on BOM upload #4533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add option to deactivate old project versions on BOM upload #4533
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
|
While not pretty this MR makes this work without any refactoring of the existing code. I can provide a refactored version of |
nscuro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also extend the other uploadBom accordingly, so they're consistent functionality-wise.
src/main/java/org/dependencytrack/resources/v1/BomResource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/resources/v1/BomResource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/resources/v1/BomResource.java
Outdated
Show resolved
Hide resolved
e59f655 to
4e90c94
Compare
Fixes DependencyTrack#4532 Signed-off-by: Christoffer Rumohr <c_rumohr@taures.de>
4e90c94 to
dfa6e6f
Compare
Done. |
|
@nscuro, I hope you’re doing well. I’m checking in to see if there’s anything else you need from me regarding this PR. I’m happy to make any further changes if needed. Thank you for your time! |
|
I'm looking for something like this. I have multiple release trains e.g. Release Trains:
At the moment the current versions are:
If I upload 10.0.3, then I would like to deactivate 10.0.2. If I upload 11.0.5 then I would like to deactivate 11.0.4. Something like minor version based. Is this a plausible requirement? At the moment I think, I will change all the pipelines that the version is only the minor part. e.g. 10.0, 11.0, 12.0 and so on. |
|
@alexsuter for sure that is possible. I would like to see the current feature set being merged before extending the scope. @nscuro for sure you have been busy with preparing yesterdays release, great work! |
|
Any news about this PR ? @crumohr It would be a very interesting feature to have |
|
Has there been any movement on this feature; I also would love to have this option as we are in a similar situation where the BOM is last in our CI pipeline and would love to have this option. |
|
I would also appreciate having this feature since we also upload our BOM files as the last step of our CI pipeline. @nscuro Are there any further inputs/changes required before this can be merged? |
Description
Fixes #4532
Addressed Issue
Current Behavior
In a continuous delivery scenario every commit to a software project creates a new version (and therefore project) in Dependency-Track. Over time there will be hundreds of "active" versions, even though they are actually not "active".
New Behavior
The
POST /v1/bomresource has another flag in addition to the already existingisLatestparameter:isActiveExclusively.When both arguments are
trueall "old" versions are deactivated and do not clutter the UI anymore.Checklist