Updating order of operations for applying patchers #1345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawrke
force-pushed
the
colored-format-strings
branch
from
edb48b8 to
a69bfc4
Compare
- this should allow for more flexibility in patching the message before it is colorized - for example, colors can be inserted on-the-fly with patches now
rawrke
changed the title
|
This is ready for review. It addresses #1344. I wanted to add a feature that allows users to configure their logs to be colorful based on the format string that is passed in to the log message. I moved around the calls to the patchers to minimize the amount of code changes. Doing so allows users to configure their logs in more ways, an example is shown in the original issue (#1344) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1344
Still a WIP