Skip to content

Veracode: Add additional severity mappings for other informational findings #8653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devGregA merged 2 commits into from
Sep 13, 2023
Merged

Veracode: Add additional severity mappings for other informational findings #8653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a1b0a7
Add additional severity mappings for other informational findings
Maffooch Sep 13, 2023
0fd5316
Update unit tests
Maffooch Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile.integration-tests-debian
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ RUN \
chrome_version=$(apt-cache show google-chrome-stable | grep Version | awk '{print $2}' | cut -d '-' -f 1) && \
chrome_version_blob=$(curl -k https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json | jq ".versions[] | select(.version==\"$chrome_version\")") && \
chromedriver_url=$(echo $chrome_version_blob | jq -r ".downloads.chromedriver[] | select(.platform==\"linux64\") | .url") && \
wget https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5790.98/linux64/chromedriver-linux64.zip && \
wget $chromedriver_url && \
unzip -j chromedriver-linux64.zip chromedriver-linux64/chromedriver && \
rm -rf chromedriver-linux64.zip && \
chmod -R 0755 .
Expand Down
3 changes: 2 additions & 1 deletion dojo/tools/veracode/json_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ class VeracodeJSONParser(object):
"""

severity_mapping = {
0: "Info",
1: "Info",
2: "Low",
3: "Medium",
Expand Down Expand Up @@ -89,7 +90,7 @@ def get_items(self, tree, test):

def create_finding_from_details(self, finding_details, scan_type, policy_violated) -> Finding:
# Fetch the common attributes that should be in every scan type
severity = self.severity_mapping.get(finding_details.get("severity", 1))
severity = self.severity_mapping.get(finding_details.get("severity", 1), 1)
# Set up the finding with just severity for now
finding = Finding(
title=f"{scan_type} Finding",
Expand Down