Skip to content

Update Orb.jsx #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Aadvait-Hirde
Copy link

I optimized the fragment shader with quality controls, added quality based pixel density, throttled mouseevents for better performance, and added an intersection observer for better performance when off-screen.

I optimized the fragment shader with quality controls, added quality based pixel density, throttled mouseevents for better performance, and added an intersection observer for better performance when off-screen.
@DavidHDev
Copy link
Owner

Please take time to understand the structure of the project before opening PRs. It seems that your code changes are AI-generated, because I don't understand why you would willingly add TypeScript code in a JSX file, it wouldn't even compile in the live server.

Keep TS in TSX files and JS in JSX files. The same goes for CSS and Tailwind. Files under /content should ONLY use CSS, while files under /tailwind do not have an external CSS file.

Besides that, if you want to help improve this, all 4 versions of this component (/content, /tailwind, /ts-default, /ts-tailwind) should be modified to contain the exact same code changes. This is also noted in CONTRIBUTING.md

Other things to watch out for:

  • Don't add comments
  • Ensure that the component behaves and looks exactly as it did before your changes
  • Post screenshots

@Aadvait-Hirde Aadvait-Hirde deleted the Aadvait-Hirde-patch-1 branch July 17, 2025 11:01
@Aadvait-Hirde
Copy link
Author

Hey David, I'd like to apologize. I'm pretty new to contributing to open-source so I should've taken the time to understand the structure properly. I stupidly forgot that this was a jsx file and not a tsx file since I cloned it off of my local repo which I was testing on, but you're completely right, my bad again!

@DavidHDev
Copy link
Owner

Not a problem, you're welcome to contribute, I just don't understand how you were able to test these changes since even defining an interface in a JSX file crashes the whole compilation.

@DavidHDev
Copy link
Owner

Oh, you tested it in a local project. All changes should be tested on the actual cloned React Bits project, it's the way to go if we want to ensure the best quality is delivered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants