Fix Dither #159
Merged
Fix Dither #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Hello @JusGu , really happy to see this PR, thanks a lot! I've tested it on Windows and my Mac, and it seems to fix the issues with the shader artifacts and the flickering |
DavidHDev
approved these changes
Mar 19, 2025
AthalarBlizz
pushed a commit
to EventHorizon-Forge/ehfcreact-bits
that referenced
this pull request
May 4, 2025
Fix Dither
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix: #118
I honestly don't fully understand why this issue only occurred on Mac and not windows but I suspect it has to do with the handling of floating‑point math/ integer conversion. I also unfortunately don't fully understand why this solution works (on a high level, I changed the way the UV pixel was calculated and messed around with the colors until they resembled the original effect) but the you're free to play around with this code.
I was able to reproduce this bug on my Mac with Intel chip which suggests this bug wasn't only on Windows devices. I fixed the bug locally on the same device, I heavily suggest testing this on a Windows device first.