OSSFuzz Integration#830
Merged
Merged
Conversation
Changed titlecase to lowercase for project name in build.sh Don't build examples or test for Crow fuzzing Signficiantly simplified corpus Added cifuzz.yml Clean up More fixes
Member
|
Building the fuzzers on GitHub has a problem, do you have an idea what is going wrong? |
Contributor
Author
@gittiver The OSSFuzz CI build will fail until this PR is merged and until I get approval for a subsequent, dependent PR to google/oss-fuzz. It is currently trying to retrieve these fuzz files from the default branch of the repository, but it is not yet there (bit of a chicken and the egg problem). |
Member
|
so we have to wait for the other approval? |
Contributor
Author
|
This PR needs to be merged first. Once you merge it, I will work with
OSS-Fuzz to begin fuzzing!
…On Thu, Jun 20, 2024 at 12:33 PM gittiver ***@***.***> wrote:
so we have to wait for the other approval?
—
Reply to this email directly, view it on GitHub
<#830 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHXFHTM6D2XJYRZZMDRZIMLZIL74TAVCNFSM6AAAAABJBKAUNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGEYDIMRWGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
Contributor
Author
|
It will try to build on merges as is, so it will show as a fail for the
CIFuzz job. It won't have an affect on any other jobs, though- so you could
just ignore the CIFuzz job until it is fully integrated with OSS-Fuzz
(Hopefully within a week's time).
…On Thu, Jun 20, 2024 at 1:00 PM gittiver ***@***.***> wrote:
This PR needs to be merged first. Once you merge it, I will work with
OSS-Fuzz to begin fuzzing!
So it will not break the build on main branch on merge? It's hard to check
if it will work before merging int.
—
Reply to this email directly, view it on GitHub
<#830 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHXFHTORNHIG4EAOUF67FDDZIMDDDAVCNFSM6AAAAABJBKAUNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGE2DSNRXGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
gittiver
approved these changes
Jun 21, 2024
jonathanmetzman
pushed a commit
to google/oss-fuzz
that referenced
this pull request
Jul 1, 2024
The harnesses and build.sh have already been integrated into master, as seen in this this [PR](CrowCpp/Crow#830) This pull request solely adds the necessary Dockerfile
andrew-guz
pushed a commit
to bgs99/Crow
that referenced
this pull request
Sep 13, 2024
Added cifuzz.yml Don't build examples or test for Crow fuzzing Changed titlecase to lowercase for project name in build.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Apologies for the long delay in getting this implemented, as discussed in Issue 744 with @gittiver.
I would greatly appreciate your review and integration of this PR.
As an overview of what next steps are for me to integrate this project fully into OSSFuzz:
Please let me know if there are any questions or concerns!