Merged
Conversation
When wrapping calls to crow from other code bases, I have had to call `operator""_method` explicitly. Breaking it into two methods, `method_from_string` and `operator""_method` allows one to compose this code elsewhere.
The-EDev
requested changes
Apr 4, 2022
Fixed extra {
The-EDev
approved these changes
Apr 4, 2022
Member
The-EDev
left a comment
The-EDev
left a comment
There was a problem hiding this comment.
Everything seems to be in order. Thank you for your work.
Contributor
Author
|
Thanks, this saves my code from saying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When wrapping calls to crow from other code bases, I have had to call
operator""_methodexplicitly. Breaking it into two methods,method_from_stringandoperator""_methodallows one to compose this code elsewhere.