Skip to content

Conversation

Code-DJ
Copy link
Contributor

@Code-DJ Code-DJ commented Jan 9, 2023

Description

Remember the window size and position across sessions.

Related Issue

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

Screen.Recording.mp4

Closes #902

@austincondiff
Copy link
Collaborator

austincondiff commented Jan 9, 2023

Will this work for multiple project windows open at once? If you can, you might post a brief screen video of this working.

@Code-DJ
Copy link
Contributor Author

Code-DJ commented Jan 9, 2023

This doesn't work for multi-project windows. Will look into it. Thanks!

@austincondiff
Copy link
Collaborator

Just to be clear, we don't currently support multiple projects in a single window. I meant each open project having its own window.

@Code-DJ Code-DJ marked this pull request as draft January 9, 2023 18:14
@Code-DJ
Copy link
Contributor Author

Code-DJ commented Jan 9, 2023

@austincondiff I did a sync fork which brought in a new commit in this PR. Is this okay - not sure if I should have done that.

@lukepistrol
Copy link
Member

@austincondiff I did a sync fork which brought in a new commit in this PR. Is this okay - not sure if I should have done that.

As long as your branch is still based on main and there are no conflicts arising, everything is good 👍🏻

@Code-DJ Code-DJ marked this pull request as ready for review January 9, 2023 21:02
@Code-DJ
Copy link
Contributor Author

Code-DJ commented Jan 9, 2023

Added screen recording above. In hindsight, should have used the mouse to quit the app instead of cmd+Q.

Copy link
Member

@lukepistrol lukepistrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍

Copy link
Member

@Wouter01 Wouter01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work!

@lukepistrol lukepistrol merged commit a46a9c4 into CodeEditApp:main Jan 9, 2023
@austincondiff
Copy link
Collaborator

Beautiful, nice work @Code-DJ!

@allcontributors add @Code-DJ for code and bug

@allcontributors
Copy link
Contributor

@austincondiff

I've put up a pull request to add @Code-DJ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Remember window size and position
4 participants