Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6bee5c5
Update ClosedXML to 0.104.1, test fail
jahav Oct 11, 2024
d4b85df
Fix SubtotalTest.WithHeaders test
jahav Oct 11, 2024
435a822
Fix SubrangesTests.Simple(Subranges_WithSubtotals_tMD2) test
jahav Oct 11, 2024
8833e37
Skip test SubrangesTests.Simple("Subranges_WithSort_tMD3.xlsx")
jahav Oct 11, 2024
c1376cc
Add comments and variable rename
jahav Nov 29, 2024
6bbd0cf
Fix SubrangesTests.MultipleSubRanges tests
jahav Nov 30, 2024
237b5bd
Move logic to TagsEvaluator
jahav Nov 30, 2024
2a89a17
Skip tag evaluation for non-text values
jahav Nov 30, 2024
ad4cc05
Fix ReportOptionsTests.DeleteOptionsWithParameter test
jahav Nov 30, 2024
13c3a13
Fix GroupTagTests.Simple(tLists3_options.xlsx | issue#111_autofilter_…
jahav Dec 11, 2024
1b49f5a
Fix failing equality sheet comparator
jahav Dec 11, 2024
37dd279
Remove Charset from styles.xml
jahav Jan 6, 2025
4a8fcb6
Update tLists1_sort.xlsx due to different sorting alg
jahav Jan 6, 2025
49a1cbd
Make skipped test explicit in test explorer
jahav Jan 7, 2025
c401abf
Fix data due to stable sort->stable sort
jahav Jan 7, 2025
e83ae30
Fix epsilon number difference in SubtotalTests.PageBreaks/WithHeaders
jahav Jan 7, 2025
b544bd6
Fix SubrangesTests.SingleEmptySubsetCorrectSum
jahav Jan 7, 2025
10e3c99
Update pivot table generation example.
jahav Jan 10, 2025
1683919
Fix data due to stable sort->stable sort
jahav Jan 22, 2025
6eeda50
Remove unnecessary dependencies from test projects
jahav Jan 22, 2025
bf2b2e1
Merge remote-tracking branch 'origin/develop' into update-to-0104
Pankraty Feb 26, 2025
d17ca2b
Fix warnings
Pankraty Feb 26, 2025
ab504b9
Merge remote-tracking branch 'origin/develop' into update-to-0104
Pankraty Feb 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix failing equality sheet comparator
The original one didn't fail on different values. Two cells could have
different values and it would declare them equal.

The property to compare value has been gone for a long time and thus
reflection always returned null. null is equal to null.
  • Loading branch information
jahav committed Dec 11, 2024
commit 1b49f5a8fc9e0bc45660cd07ed1e40367252b1f2
2 changes: 1 addition & 1 deletion tests/ClosedXML.Report.Tests/XlsxTemplateTestsBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ protected bool WorksheetsAreEqual(IXLWorksheet expected, IXLWorksheet actual, ou
var actualCell = actual.Cell(address);
bool cellsAreEqual = true;

if (!expectedCell.HasFormula && !actualCell.HasFormula && actualCell.GetInnerText() != expectedCell.GetInnerText())
if (!expectedCell.HasFormula && !actualCell.HasFormula && actualCell.Value.ToString() != expectedCell.Value.ToString())
{
messages.Add($"Cell values are not equal starting from {address}");
cellsAreEqual = false;
Expand Down
Loading