Conversation
…ows, instead to the refresh. This fixes #6490. Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary UI freeze/thaw operations when updating notification windows and replaces them with a single refresh call to improve performance and fix issue #6490.
- Removes
Freeze()andThaw()calls around notification list updates - Adds a
Refresh()call to ensure the UI is properly updated
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Freeze(); | ||
| SetItemCount(noticeCount); | ||
| m_bDisplayFetchingNotices = false; | ||
| m_bDisplayEmptyNotice = false; |
There was a problem hiding this comment.
Consider moving the Refresh() call after all member variable updates are complete. Currently, Refresh() is called immediately after SetItemCount() but before updating the display flags, which could cause an unnecessary intermediate redraw.
Suggested change
| m_bDisplayEmptyNotice = false; | |
| m_bDisplayEmptyNotice = false; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #6490.