Conversation
added 2 commits
July 24, 2025 07:31
Contributor
Author
|
This is ready to merge when CI checks complete successfully |
Member
|
@CharlieFenton, please fix this error: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements macOS 26 screensaver functionality fixes for BOINC, addressing two key issues: proper operation of the BOINC screensaver coordinator under the legacy screensaver engine, and restoration of programmatic screensaver selection capability that was broken in macOS 14-15.
Key changes include:
- Enhanced BOINC_Finish_Install utility with macOS 26 screensaver setting capabilities and improved localization support
- Restructured installer architecture to place BOINC_Finish_Install in the BOINC Data folder instead of user directories
- Improved screensaver engine stability and lifecycle management with better signal handling and resource cleanup
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| mac_installer/release_brand.sh | Updates build script to include AddRemoveUser executable and restructures BOINC_Finish_Install placement |
| mac_installer/release_boinc.sh | Mirrors branding script changes and removes obsolete embedded finish install handling |
| mac_installer/finish_install.cpp | Adds macOS 26 screensaver setting functionality, localization support, and improved argument parsing |
| mac_installer/PostInstall.cpp | Removes legacy screensaver setting code and updates to use centralized finish install location |
| mac_build/boinc.xcodeproj/* | Updates Xcode project configuration for new build dependencies and finish install handling |
| clientscr/.cpp/.m | Improves screensaver engine stability with better lifecycle management and signal handling |
| clientgui/mac/templates/*.plist | Updates plist templates with corrected DTD references and icon specifications |
| client/*.cpp | Minor logging improvements and security check updates for branded installations |
Comments suppressed due to low confidence (1)
clientscr/Mac_Saver_ModuleView.m:147
- The comment 'CAF' is unclear and should be expanded to explain what it stands for or its purpose in this context.
bool gIsBigSur = false;
AenBleidd
approved these changes
Jul 25, 2025
Member
|
@CharlieFenton, is it ready to be merged? |
Contributor
Author
|
@AenBleidd Not quite yet. I want to investigate Copilot's latest comments first |
Contributor
Author
|
@AenBleidd This should be ready to merge now. |
AenBleidd
approved these changes
Jul 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates 2 aspects of BOINC screensaver logic for MacOS 25:
This code is backward compatible with earlier versions of MacOS, so it can be merged into all new releases of BOINC.