make buttons more legible #5698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bootstrap 'btn-success' colors are white text on light green.
This is hard to read.
Change this to a darker green (seagreen).
There are two cases: form submit buttons, and links.
Lots of each; not sure I got them all.
Each of these should be factored into a single function; maybe later.
Also:
- use sprintf() instead of "foo".tra("xxx")."blah"
- fix sending HTML email with linux 'mail' command
- fix display of friends
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5698 +/- ##
============================================
- Coverage 10.53% 10.53% -0.01%
Complexity 1068 1068
============================================
Files 279 279
Lines 35871 35874 +3
Branches 8411 8412 +1
============================================
Hits 3780 3780
- Misses 31697 31700 +3
Partials 394 394 |
AenBleidd
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use a darker green than the bootstrap 'success' color