-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add AttemptNumber to HedgingPredicateArguments #2603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AttemptNumber to HedgingPredicateArguments #2603
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2603 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 311 311
Lines 7327 7329 +2
Branches 1013 1013
=======================================
+ Hits 7051 7053 +2
Misses 222 222
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
test/Polly.Core.Tests/Hedging/HedgingPredicateArgumentsTests.cs
Outdated
Show resolved
Hide resolved
|
Looks like we don't have an "end-to-end" test change anywhere that asserts that the attempt number correctly increments. |
|
Thanks for your contribution @peter-csala - the changes from this pull request have been published as part of version 8.6.0 📦, which is now available from NuGet.org 🚀 |
Pull Request
The issue or feature being addressed
#2602
Details on the issue fix or feature implementation
The API is not the most convenient, but backward compatible.
Confirm the following