Skip to content

Conversation

@peter-csala
Copy link
Contributor

@peter-csala peter-csala commented Apr 30, 2025

Pull Request

The issue or feature being addressed

#2602

Details on the issue fix or feature implementation

The API is not the most convenient, but backward compatible.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (9602a0e) to head (9c45623).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2603   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         311      311           
  Lines        7327     7329    +2     
  Branches     1013     1013           
=======================================
+ Hits         7051     7053    +2     
  Misses        222      222           
  Partials       54       54           
Flag Coverage Δ
linux 96.23% <100.00%> (+<0.01%) ⬆️
macos 96.23% <100.00%> (+<0.01%) ⬆️
windows 96.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peter-csala peter-csala changed the title Add attemptnumber to HedgingPredicateArguments Add AttemptNumber to HedgingPredicateArguments May 3, 2025
@peter-csala peter-csala marked this pull request as ready for review May 3, 2025 05:37
@martincostello
Copy link
Member

Looks like we don't have an "end-to-end" test change anywhere that asserts that the attempt number correctly increments.

@martincostello martincostello added this to the v8.5.3 milestone May 4, 2025
@martincostello martincostello merged commit 198b42a into App-vNext:main May 4, 2025
26 checks passed
@github-actions
Copy link
Contributor

Thanks for your contribution @peter-csala - the changes from this pull request have been published as part of version 8.6.0 📦, which is now available from NuGet.org 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants