Merged
Conversation
Member
|
Thanks for the PR - to merge this, either unit tests need to be added to improve the coverage, or the coverage baselines need to be adjusted to account for all the additional lines of code that are not covered now that all the checks have been expanded to two lines instead of one. |
Contributor
Author
|
Thank you for your review and feedback! I will add more unit tests to achieve the necessary coverage. |
02320c5 to
540e308
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1957 +/- ##
==========================================
- Coverage 85.90% 83.23% -2.67%
==========================================
Files 312 312
Lines 6647 7106 +459
Branches 1056 1056
==========================================
+ Hits 5710 5915 +205
- Misses 540 806 +266
+ Partials 397 385 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martincostello
approved these changes
Feb 16, 2024
4 tasks
This was referenced Aug 26, 2025
This was referenced Sep 29, 2025
This was referenced Dec 8, 2025
This was referenced Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
Contributes to #1290
Details on the issue fix or feature implementation
Fix SA1501 and IDE0055.
Confirm the following