Refactor remaining deprecated Ember code#250
Merged
Conversation
Replace computed properties with getter methods and, where appropriate, use the @cached decorator. See https://emberjs.github.io/rfcs/0566-memo-decorator.html for documentation of the decorator.
Routes are not supposed to access the controller from actions.
Don't rely on actions bubbling up the route hierarchy anymore. Instead they should be passed as explicit method references.
Accessing the controller from the route outside of setupController/resetController is discouraged.
This helps with password managers.
input fields with an `id` and `aria-label` attribute trigger a linter warning
All linter warnings have been fixed, so we can just use ember/recommended again.
raucao
approved these changes
Nov 25, 2021
Member
raucao
left a comment
raucao
left a comment
There was a problem hiding this comment.
This is fantastic! 👏 🎉
I pushed a small commit to fix the CodeClimate warning. No attribution necessary.
raucao
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes all remaining linter warnings.